[feedhenry-dev] How are PRs to open source repos reviewed?

Daniel Passos dpassos at redhat.com
Thu Nov 17 20:11:04 UTC 2016


There is an option on Github to receive an email for every new PR. I think
you can configure it for all repo or only for the repos you want.

On Thu, Nov 17, 2016 at 6:05 PM, Martin Murphy <mmurphy at redhat.com> wrote:

> Thanks Passos.
>
> That would mean that someone on the team would have to be looking out
> for PRs to the open source repos.
> Do you know if we have that in place for all our open source repos?
>
> Cheers,
> M.
>
>
> On 17 November 2016 at 19:44, Daniel Passos <dpassos at redhat.com> wrote:
> > What we have been doing on AeroGear is:
> >
> > 1) If the PR came from the community?
> >
> > * Check is there is a Jira for this one, if not create one and link the
> PR
> > * Ping someone with more knowledgement about the project to review this
> one
> >
> > Example: https://github.com/aerogear/aerogear-ios-http/pull/73
> >                 https://github.com/aerogear/aerogear-ios-oauth2/pull/61
> >
> >
> > 2) If the PR came from the team
> >
> > * Add the Jira about the PR in the PR
> > * Ping someone with more knowledge about the project to review this one
> >
> > Example: https://github.com/aerogear/aerogear-android-auth/pull/37
> >
> > Bonus point to comment using reaction gifts[1]
> >
> > [1] http://www.reactiongifs.com/
> >
> >
> > On Thu, Nov 17, 2016 at 5:23 PM, Martin Murphy <mmurphy at redhat.com>
> wrote:
> >>
> >> How are PRs to open source repos reviewed?
> >> e.g. if someone submits a PR for fh-fhc, is that enough to get a review?
> >> Or do they have to ping someone/someplace?
> >>
> >> Cheers,
> >> M.
> >>
> >> _______________________________________________
> >> feedhenry-dev mailing list
> >> feedhenry-dev at redhat.com
> >> https://www.redhat.com/mailman/listinfo/feedhenry-dev
> >
> >
> >
> >
> > --
> > -- Passos
>



-- 
-- Passos
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/feedhenry-dev/attachments/20161117/79c3e2ce/attachment.htm>


More information about the feedhenry-dev mailing list