From supittma at redhat.com Wed Jan 11 15:26:52 2017 From: supittma at redhat.com (Summers Pittman) Date: Wed, 11 Jan 2017 10:26:52 -0500 Subject: [feedhenry-dev] Weird behavior in fh-mbaas-express Message-ID: Hey guys, While I was debugging this stack trace [ https://gist.github.com/secondsun/16088b4212394140b9053a448d7faf63] in Raincatcher I came across this area of code : https://github.com/feedhenry/fh-mbaas-express/blob/master/lib/mbaas.js#L156 It looks like when request can't connect to a service, err.code is set to 0. Since 0 isn't a valid status code the library will crash the application instead of properly returning an error to the application. I tried doing a check for (err.code === 0) and setting values differently, but this block doesn't execute and the error persists. What should the correct way to handle this situation be? Summers -------------- next part -------------- An HTML attachment was scrubbed... URL: From phaji at redhat.com Wed Jan 11 15:36:33 2017 From: phaji at redhat.com (Paolo Haji) Date: Wed, 11 Jan 2017 13:36:33 -0200 Subject: [feedhenry-dev] Weird behavior in fh-mbaas-express In-Reply-To: References: Message-ID: It's definitely weird that the stack trace points to that line since (0 || 500) === 500 On Wed, Jan 11, 2017 at 1:26 PM, Summers Pittman wrote: > Hey guys, > > While I was debugging this stack trace [https://gist.github.com/secondsun/ > 16088b4212394140b9053a448d7faf63] in Raincatcher I came across this area > of code : https://github.com/feedhenry/fh-mbaas-express/ > blob/master/lib/mbaas.js#L156 > > It looks like when request can't connect to a service, err.code is set to > 0. Since 0 isn't a valid status code the library will crash the > application instead of properly returning an error to the application. > > I tried doing a check for (err.code === 0) and setting values differently, > but this block doesn't execute and the error persists. > > What should the correct way to handle this situation be? > > Summers > > > > _______________________________________________ > feedhenry-dev mailing list > feedhenry-dev at redhat.com > https://www.redhat.com/mailman/listinfo/feedhenry-dev > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From weil at redhat.com Wed Jan 11 15:39:23 2017 From: weil at redhat.com (Wei Li) Date: Wed, 11 Jan 2017 15:39:23 +0000 Subject: [feedhenry-dev] Weird behavior in fh-mbaas-express In-Reply-To: References: Message-ID: Is it possible that err.code is "0" (string type), rather than 0 (number type)? On Wed, Jan 11, 2017 at 3:36 PM, Paolo Haji wrote: > It's definitely weird that the stack trace points to that line since (0 || > 500) === 500 > > On Wed, Jan 11, 2017 at 1:26 PM, Summers Pittman > wrote: > >> Hey guys, >> >> While I was debugging this stack trace [https://gist.github.com/secon >> dsun/16088b4212394140b9053a448d7faf63] in Raincatcher I came across this >> area of code : https://github.com/feedhenry/fh-mbaas-express/blob/master/ >> lib/mbaas.js#L156 >> >> It looks like when request can't connect to a service, err.code is set to >> 0. Since 0 isn't a valid status code the library will crash the >> application instead of properly returning an error to the application. >> >> I tried doing a check for (err.code === 0) and setting values >> differently, but this block doesn't execute and the error persists. >> >> What should the correct way to handle this situation be? >> >> Summers >> >> >> >> _______________________________________________ >> feedhenry-dev mailing list >> feedhenry-dev at redhat.com >> https://www.redhat.com/mailman/listinfo/feedhenry-dev >> >> > > _______________________________________________ > feedhenry-dev mailing list > feedhenry-dev at redhat.com > https://www.redhat.com/mailman/listinfo/feedhenry-dev > > -- Wei Li Red Hat email address: wei.li at redhat.com Senior Software Engineer -------------- next part -------------- An HTML attachment was scrubbed... URL: From supittma at redhat.com Wed Jan 11 16:13:02 2017 From: supittma at redhat.com (Summers Pittman) Date: Wed, 11 Jan 2017 11:13:02 -0500 Subject: [feedhenry-dev] Weird behavior in fh-mbaas-express In-Reply-To: References: Message-ID: On Wed, Jan 11, 2017 at 10:39 AM, Wei Li wrote: > Is it possible that err.code is "0" (string type), rather than 0 (number > type)? > > That seems to be it. > On Wed, Jan 11, 2017 at 3:36 PM, Paolo Haji wrote: > >> It's definitely weird that the stack trace points to that line since (0 >> || 500) === 500 >> >> On Wed, Jan 11, 2017 at 1:26 PM, Summers Pittman >> wrote: >> >>> Hey guys, >>> >>> While I was debugging this stack trace [https://gist.github.com/secon >>> dsun/16088b4212394140b9053a448d7faf63] in Raincatcher I came across >>> this area of code : https://github.com/feedhenry >>> /fh-mbaas-express/blob/master/lib/mbaas.js#L156 >>> >>> It looks like when request can't connect to a service, err.code is set >>> to 0. Since 0 isn't a valid status code the library will crash the >>> application instead of properly returning an error to the application. >>> >>> I tried doing a check for (err.code === 0) and setting values >>> differently, but this block doesn't execute and the error persists. >>> >>> What should the correct way to handle this situation be? >>> >>> Summers >>> >>> >>> >>> _______________________________________________ >>> feedhenry-dev mailing list >>> feedhenry-dev at redhat.com >>> https://www.redhat.com/mailman/listinfo/feedhenry-dev >>> >>> >> >> _______________________________________________ >> feedhenry-dev mailing list >> feedhenry-dev at redhat.com >> https://www.redhat.com/mailman/listinfo/feedhenry-dev >> >> > > > -- > Wei Li > Red Hat email address: wei.li at redhat.com > Senior Software Engineer > -------------- next part -------------- An HTML attachment was scrubbed... URL: From weil at redhat.com Wed Jan 11 16:58:15 2017 From: weil at redhat.com (Wei Li) Date: Wed, 11 Jan 2017 16:58:15 +0000 Subject: [feedhenry-dev] Weird behavior in fh-mbaas-express In-Reply-To: References: Message-ID: ah, the "beauty" of javascript ;) On Wed, Jan 11, 2017 at 4:13 PM, Summers Pittman wrote: > > > On Wed, Jan 11, 2017 at 10:39 AM, Wei Li wrote: > >> Is it possible that err.code is "0" (string type), rather than 0 (number >> type)? >> >> > That seems to be it. > > > >> On Wed, Jan 11, 2017 at 3:36 PM, Paolo Haji wrote: >> >>> It's definitely weird that the stack trace points to that line since (0 >>> || 500) === 500 >>> >>> On Wed, Jan 11, 2017 at 1:26 PM, Summers Pittman >>> wrote: >>> >>>> Hey guys, >>>> >>>> While I was debugging this stack trace [https://gist.github.com/secon >>>> dsun/16088b4212394140b9053a448d7faf63] in Raincatcher I came across >>>> this area of code : https://github.com/feedhenry >>>> /fh-mbaas-express/blob/master/lib/mbaas.js#L156 >>>> >>>> It looks like when request can't connect to a service, err.code is set >>>> to 0. Since 0 isn't a valid status code the library will crash the >>>> application instead of properly returning an error to the application. >>>> >>>> I tried doing a check for (err.code === 0) and setting values >>>> differently, but this block doesn't execute and the error persists. >>>> >>>> What should the correct way to handle this situation be? >>>> >>>> Summers >>>> >>>> >>>> >>>> _______________________________________________ >>>> feedhenry-dev mailing list >>>> feedhenry-dev at redhat.com >>>> https://www.redhat.com/mailman/listinfo/feedhenry-dev >>>> >>>> >>> >>> _______________________________________________ >>> feedhenry-dev mailing list >>> feedhenry-dev at redhat.com >>> https://www.redhat.com/mailman/listinfo/feedhenry-dev >>> >>> >> >> >> -- >> Wei Li >> Red Hat email address: wei.li at redhat.com >> Senior Software Engineer >> > > -- Wei Li Red Hat email address: wei.li at redhat.com Senior Software Engineer -------------- next part -------------- An HTML attachment was scrubbed... URL: From weil at redhat.com Fri Jan 13 10:32:19 2017 From: weil at redhat.com (Wei Li) Date: Fri, 13 Jan 2017 10:32:19 +0000 Subject: [feedhenry-dev] Some very good tips about how to write clean javascript Message-ID: https://github.com/ryanmcdermott/clean-code-javascript -- Wei Li Red Hat email address: wei.li at redhat.com Senior Software Engineer -------------- next part -------------- An HTML attachment was scrubbed... URL: From phajidec at redhat.com Fri Jan 13 11:44:58 2017 From: phajidec at redhat.com (Paolo Haji) Date: Fri, 13 Jan 2017 09:44:58 -0200 Subject: [feedhenry-dev] Some very good tips about how to write clean javascript In-Reply-To: References: Message-ID: Lots of nice patterns using ES6 features! It's a bit sad to see a lot of recommendations around basic OOP principles, as an indicator that we need to remind ourselves constantly that they still apply despite all the duck typing, some of which are enforced at the language level in other languages (i.e. Liskov, though their example is really nice since it would break static checking) Another resource I really like that has almost the opposite goal (understand ES5 crazyness) is John Resig's (creator of JQuery) Learning Advanced Javascript here: http://ejohn.org/apps/learn/ On Fri, Jan 13, 2017 at 8:32 AM, Wei Li wrote: > https://github.com/ryanmcdermott/clean-code-javascript > > -- > Wei Li > Red Hat email address: wei.li at redhat.com > Senior Software Engineer > > _______________________________________________ > feedhenry-dev mailing list > feedhenry-dev at redhat.com > https://www.redhat.com/mailman/listinfo/feedhenry-dev > > -- Paolo Bueno Software Engineer Red Hat Mobile Application Platform -------------- next part -------------- An HTML attachment was scrubbed... URL: From omatskiv at redhat.com Fri Jan 13 13:17:54 2017 From: omatskiv at redhat.com (Oleg Matskiv) Date: Fri, 13 Jan 2017 14:17:54 +0100 Subject: [feedhenry-dev] Some very good tips about how to write clean javascript In-Reply-To: References: Message-ID: Thank you for sharing this. Pretty good examples in there. On Fri, Jan 13, 2017 at 11:32 AM, Wei Li wrote: > https://github.com/ryanmcdermott/clean-code-javascript > > -- > Wei Li > Red Hat email address: wei.li at redhat.com > Senior Software Engineer > > _______________________________________________ > feedhenry-dev mailing list > feedhenry-dev at redhat.com > https://www.redhat.com/mailman/listinfo/feedhenry-dev > > -- Oleg Matskiv Associate Quality Engineer Red Hat Mobile Application Platform omatskiv at redhat.com -------------- next part -------------- An HTML attachment was scrubbed... URL: From wtrocki at redhat.com Sun Jan 22 14:49:49 2017 From: wtrocki at redhat.com (Wojciech Trocki) Date: Sun, 22 Jan 2017 14:49:49 +0000 Subject: [feedhenry-dev] New feedhenry community contributors Message-ID: Hi everyone We would like to thank *camilamacedo86* and alanmoran for recent contributions to the Feeedhenry platform. Camila done improvements around various platform components and helped us to verify and track open source issues. Alan helped us on on fh-fhc, by sending multiple PR's around the most used functionalities. Thank You for awesome work done to improve Feedhenry open source projects! Regards -- Wojciech Trocki Software Engineer, Red Hat Mobile -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: logo.png Type: image/png Size: 11472 bytes Desc: not available URL: From mwessend at redhat.com Mon Jan 23 11:24:36 2017 From: mwessend at redhat.com (Matthias Wessendorf) Date: Mon, 23 Jan 2017 12:24:36 +0100 Subject: [feedhenry-dev] New feedhenry community contributors In-Reply-To: References: Message-ID: w00t On Sun, Jan 22, 2017 at 3:49 PM, Wojciech Trocki wrote: > Hi everyone > > We would like to thank *camilamacedo86* > and alanmoran > for recent contributions to the > Feeedhenry platform. > > Camila done improvements around various platform components and helped us > to verify and track open source issues. > > Alan helped us on on fh-fhc, by sending multiple PR's around the most used > functionalities. > > Thank You for awesome work done to improve Feedhenry open source projects! > > Regards > -- > Wojciech Trocki > Software Engineer, Red Hat Mobile > > > _______________________________________________ > feedhenry-dev mailing list > feedhenry-dev at redhat.com > https://www.redhat.com/mailman/listinfo/feedhenry-dev > > -- Project lead AeroGear.org -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: logo.png Type: image/png Size: 11472 bytes Desc: not available URL: From pwright at redhat.com Mon Jan 23 15:22:25 2017 From: pwright at redhat.com (paul wright) Date: Mon, 23 Jan 2017 15:22:25 +0000 Subject: [feedhenry-dev] Template Cleanup Message-ID: <5154afc1-3c57-adc8-dbd9-100b48f1dff8@redhat.com> RFC on a new Template naming scheme Hi, Template names should be consistent and provide just enough information for user to understand context. Details can be included in description (eg whether the resulting app will echo ?hello world?), or in the category. Proposal 1 [RHMAP*](Technology...)[](Project|Cloud App|Client App|Forms App)[] * Indicates official support, distinguishes template from customer template For example RHMAP iOS Swift Starter Client App RHMAP iOS Objective-C Client App for SAML Proposal 2 [Red Hat*](Technology...)[](Project|Cloud App|Client App|Forms App)[] * Indicates official support, distinguishes template from customer/upstream template For example: Red Hat iOS Swift SAML Example Client App to demonstrate Authentication Red Hat Cordova Starter Forms App loosely relates to http://feedhenry-dev.2363497.n4.nabble.com/Renaming-Hello-World-Temapltes-td28.html Paul