[Feedhenry-raincatcher] Issue with Regex module on Windows

Wojciech Trocki wtrocki at redhat.com
Fri Dec 1 13:38:06 UTC 2017


After sync with Austin we found that problem was related with the different
representation of the path "/:datasetId" on windows that was causing
regular expression issues.
This was happening only when working in windows cmd.
We currently working on hotfix.

On Fri, Dec 1, 2017 at 12:06 PM, Darach Cawley <dcawley at redhat.com> wrote:

> Thanks guys!
>
> This is the latest out of the box raincatcher demo server which is being
> run, so nothing changed.
>
> On Fri, Dec 1, 2017 at 8:38 AM, Austin Cunningham <aucunnin at redhat.com>
> wrote:
>
>> Replicated this last night when running npm start from cmd . As far as I
>> know git bash terminal can be setup with cmd as its default shell.
>>
>> On 30 November 2017 at 21:32, Wojciech Trocki <wtrocki at redhat.com> wrote:
>>
>>> I could not replicate this exact problem on Windows 10 with git bash.
>>>
>>>
>>>
>>> On Thu, Nov 30, 2017 at 5:26 PM, Wojciech Trocki <wtrocki at redhat.com>
>>> wrote:
>>>
>>>> Introduction
>>>>
>>>> RainCatcher allows users to mount sync endpoints to custom routes.
>>>> This can fail when someone is passing invalid regular expression path
>>>> to express[0]
>>>>
>>>> In this particular example path can be passed as first argument to [1]
>>>> method.
>>>> This argument will be used to create route, which fails later on
>>>> windows.
>>>>
>>>> I'm trying out now to replicate problem on one of the windows machines
>>>> I have access to.
>>>> Problem can be replicated on any machine when passing invalid regexp as
>>>> argument to [1].
>>>>
>>>> Questions:
>>>>
>>>> *1) Is sync api path location in [1] customized? *
>>>> *2) Is it possible to replicate this problem on latest release (1.1.0)
>>>> without any changes?*
>>>>
>>>> PS: It's good to send package.json from this project will help us to
>>>> see what versions we can use to replicate this issue.
>>>>
>>>> [0] https://github.com/expressjs/express/issues/2034
>>>> [1] https://github.com/feedhenry-raincatcher/raincatcher-cor
>>>> e/blob/v0.0.5/demo/server/src/modules/index.ts#L70
>>>> [2] https://github.com/feedhenry-raincatcher/raincatcher-cor
>>>> e/blob/v0.0.5/cloud/datasync/src/web/SyncWebExpress.ts#L26
>>>>
>>>> On Thu, Nov 30, 2017 at 5:13 PM, Paolo Haji <phajidec at redhat.com>
>>>> wrote:
>>>>
>>>>> From what I can guess from the output it might be a different behavior
>>>>> of regex parsing on windows?
>>>>>
>>>>> Looks like /^\(?:([^\/]+?))\/?$/ should be /^\(?:([^\/]+?)\)\/?$/
>>>>>
>>>>> I'll try to make a minimal reproduction and open an issue at either
>>>>> path-to-regexp or express itself.
>>>>>
>>>>> Do you guys have a package-lock or shrinkwrap file to attach? Would
>>>>> help reproducing the issue. IMO it should affect non-windows environments
>>>>> too.
>>>>>
>>>>> On Thu, Nov 30, 2017 at 3:03 PM, Darach Cawley <dcawley at redhat.com>
>>>>> wrote:
>>>>>
>>>>>> Hi guys,
>>>>>>
>>>>>> Have you seen this issue before on starting the server for the first
>>>>>> time?
>>>>>> See screenshot below.
>>>>>>
>>>>>> *NOTE: Using Node 6 on Windows.*
>>>>>>
>>>>>> [image: Inline image 1]
>>>>>>
>>>>>> Any help would be really help.
>>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>> --
>>>>>>
>>>>>> Darach Cawley
>>>>>>
>>>>>> Senior Consultant
>>>>>>
>>>>>> Red Hat Mobile
>>>>>>
>>>>>> dcawley at redhat.com     T: 051810130     IM: dcawley
>>>>>>
>>>>>> www.redhat.com | TRIED. TESTED. TRUSTED. | redhat.com/trusted
>>>>>>
>>>>>> _______________________________________________
>>>>>> Feedhenry-raincatcher mailing list
>>>>>> Feedhenry-raincatcher at redhat.com
>>>>>> https://www.redhat.com/mailman/listinfo/feedhenry-raincatcher
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>>
>>>>> PAOLO HAJI
>>>>>
>>>>> SOFTWARE ENGINEER, RED HAT MOBILE APPLICATION PLATFORM
>>>>>
>>>>> Red Hat Brasil <https://www.redhat.com/>
>>>>>
>>>>> phaji at redhat.com
>>>>> <https://red.ht/sig>
>>>>> TRIED. TESTED. TRUSTED. <https://redhat.com/trusted>
>>>>>
>>>>> _______________________________________________
>>>>> Feedhenry-raincatcher mailing list
>>>>> Feedhenry-raincatcher at redhat.com
>>>>> https://www.redhat.com/mailman/listinfo/feedhenry-raincatcher
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>>
>>>> WOJCIECH TROCKI
>>>>
>>>> Red Hat Mobile <https://www.redhat.com/>
>>>>
>>>> IM: wtrocki
>>>> <https://red.ht/sig>
>>>>
>>>
>>>
>>>
>>> --
>>>
>>> WOJCIECH TROCKI
>>>
>>> Red Hat Mobile <https://www.redhat.com/>
>>>
>>> IM: wtrocki
>>> <https://red.ht/sig>
>>>
>>> _______________________________________________
>>> Feedhenry-raincatcher mailing list
>>> Feedhenry-raincatcher at redhat.com
>>> https://www.redhat.com/mailman/listinfo/feedhenry-raincatcher
>>>
>>>
>>
>>
>> --
>>
>> Austin Cunningham
>>
>> Associate Software Engineer - Mobile
>>
>> Red Hat Mobile <https://www.redhat.com>
>>
>> Communications House, Cork Road, Waterford X91NY33
>>
>> Ireland
>>
>> aucunnin at redhat.com
>> <https://red.ht/sig>
>>
>>
>>
>> _______________________________________________
>> Feedhenry-raincatcher mailing list
>> Feedhenry-raincatcher at redhat.com
>> https://www.redhat.com/mailman/listinfo/feedhenry-raincatcher
>>
>>
>
>
> --
>
> Darach Cawley
>
> Senior Consultant
>
> Red Hat Mobile
>
> dcawley at redhat.com     T: 051810130     IM: dcawley
>
> www.redhat.com | TRIED. TESTED. TRUSTED. | redhat.com/trusted
>



-- 

WOJCIECH TROCKI

Red Hat Mobile <https://www.redhat.com/>

IM: wtrocki
<https://red.ht/sig>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/feedhenry-raincatcher/attachments/20171201/4f0068ff/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image.png
Type: image/png
Size: 243323 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/feedhenry-raincatcher/attachments/20171201/4f0068ff/attachment.png>


More information about the Feedhenry-raincatcher mailing list