From jgranado at redhat.com Thu Oct 23 17:38:50 2008 From: jgranado at redhat.com (Joel Granados) Date: Thu, 23 Oct 2008 13:38:50 -0400 (EDT) Subject: [Firstaidkit-devel] New revert functionality In-Reply-To: <1548108188.2898371224783528760.JavaMail.root@zmail01.collab.prod.int.phx2.redhat.com> Message-ID: <1458854838.2898391224783530862.JavaMail.root@zmail01.collab.prod.int.phx2.redhat.com> Hey Fak people: These patches are ment to implement the new revert functionality. The idea is to have the revert code somewhat separate from the main firstaidkit code. It just make life easiear. Some changes went in to the backup code to make this work. At the moment I have the grub plugin using the new revert stuff. Out of all the changes made to fak I still feel somewhat doubtfull about the way that the naming of the backup directories was handled. Any ideas to make this more genera are appreciated. Trying to make the names valid between python virtual machines I decided to name the directories (or rather to require the plugins to name the directories) with their module name. not the complete name, but the last strint after the dot "." of the complete name. What im trying to do here is for the plugin to be recognizable by the user by its module name (the short one, grub as apposed to pyfirstaidkit.plugins.grub.grub) both in firstaidkit and firstaidkitrevert. Considering that there is a possibility of having a full module name that is different on different executions (it all depends on how you import the module) I decided to go with the module name. Couldnt think of any major porblems with respect to this approach. other than having two plugins with the same name. But we don't consider that anyway in firstaidkit. comments appreciated. Regards. patches are attached. -- Joel Andres Granados Red Hat / Brno Czech Republic -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-Add-the-revert-functionality-to-firstaidkit.patch Type: application/octet-stream Size: 12485 bytes Desc: not available URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: 0002-Create-the-revert-function-for-the-grub-plugin.patch Type: application/octet-stream Size: 3688 bytes Desc: not available URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: 0003-Create-a-new-argument-reverting-for-the-BackupPers.patch Type: application/octet-stream Size: 6831 bytes Desc: not available URL: