[Firstaidkit-devel] [PATCH] Add volume_key plugin
Joel Granados
jgranado at redhat.com
Sun Jul 19 10:08:59 UTC 2009
Miroslav.
This is great!! I have a comment about the way you post the patches.
Its much better IMO to use the commands provided by git to create and
send patches. This will put each patch in a separate email and will
give the reviewer context when he is reading your mail. I also think
that its much easier (I have to type just two lines).
Take a look at http://jgranado.fedorapeople.org/git_scripts/. Those are
the scritps that I am currently using to send patches everywhere.
Thx again.
Regards.
On Fri, Jul 17, 2009 at 10:08:24AM -0400, Miloslav Trmac wrote:
> Hello,
> the attached patches add support for key recovery using volume_key. They depend on question support submitted earlier, and on python-volume_key, which is currently blocked in Fedora review (#508954). The first patch (adding the plugin) can be applied immediately - the plugin will be silently ignored if "import volume_key" fails. The second patch (updating packaging) will have to wait until python-volume_key is available in repositories.
>
> Thank you,
> Mirek
> _______________________________________________
> Firstaidkit-devel mailing list
> Firstaidkit-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/firstaidkit-devel
--
Joel Andres Granados
Brno, Czech Republic, Red Hat.
More information about the Firstaidkit-devel
mailing list