[Freeipa-devel] [PATCH] one more try at arguments patch

Rob Crittenden rcritten at redhat.com
Thu Aug 23 13:09:31 UTC 2007


Hopefully the last patch for this.

Kevin prodded me to work out this final, much more streamlined solution. 
A lot of the problems were associated with using encode_args and 
decode_args, code I ripped from koji. After dropping that and simply 
always plopping opts onto the end of every XML-RPC call things magically 
started working much nicer. opts, as you might recall, holds the 
kerberos principal name that Apache needs to pass to us.

The changelog is:

Handle optional arguments by using the value __NONE__ over XML-RPC.
   rpcclient.py must call XML-RPC functions with all arguments.
Removed encode_args and decode_args. They were the source of most of the
   argument pain. Now opts is alwyas appended to the end of the arguments
   so MUST be the last argument in any server-side function (can be None)
Allow the User object to handle unicode data
Small fixes to command-line tools to be friendlier
Broke out get_user() into get_user_by_dn() and get_user_by_uid()
Need to request more than just 'nsAccountLock' attribute when trying to
   see if a user is already marked deleted. If it is blank the record
   coming back is empty. Add 'uid' to the list to guarantee something coming
   back (dn is handled specially)
Added user_container attribute to get_user_* and add_user so the caller
   can specify where in the tree the user will be searched for/added.
Added global default value for user_container

rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-121-fixargs.patch
Type: text/x-patch
Size: 19196 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20070823/07dd25d6/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3245 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20070823/07dd25d6/attachment-0001.bin>


More information about the Freeipa-devel mailing list