[Freeipa-devel] [PATCH] Delete users/groups, add group to group

Kevin McCarthy kmccarth at redhat.com
Mon Aug 27 20:50:40 UTC 2007


Rob Crittenden wrote:
> Implement delete users and groups
> Implement adding a group to a group
> Some other small fixups
> Add new cmd-line tool ipa-delgroup

Looks good.

For a later patch:
- I've been wrapping the LDAP connection in try/finally blocks (see my
  last patch).  It would be good if you could add that to your new
  methods.

- As your email just mentioned, we'll need to be careful to unwrap
  binary data in xmlrpc calls.   It would be good to put
  return ipautil.unwrap_binary_data(result)
  for every method in rpcclient, even when the result doesn't contain
  binary data (to prevent copy/paste accidents).

-Kevin

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 2228 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20070827/7f210366/attachment.bin>


More information about the Freeipa-devel mailing list