[Freeipa-devel] [PATCH] conver ipa-server-setupssl to python
Rob Crittenden
rcritten at redhat.com
Fri Dec 7 22:07:08 UTC 2007
Karl MacMillan wrote:
> On Fri, 2007-12-07 at 09:18 -0500, Rob Crittenden wrote:
>> Karl MacMillan wrote:
>>> Convert the setup of ssl from a shell script to a
>>> python module. This is in preparation for user
>>> supplied certs.
>>>
>>>
>> A good start but there are a number of issues with this:
>>
>
> Updated patch attached.
>
Need to put a try/except around ipautil.run calls in certs.py
Probably need to put a try/except around os.rename calls in ipautil.py
I don't think there is a need to backup any existing noise files. In
fact, we probably want to remove this when we're done generating certs.
As a style thing you have a bunch of whitespace at the end of certs.py :-)
Otherwise looks fine. I wrote a little stub program that uses this
module and it worked fine.
rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3245 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20071207/20f16b23/attachment.bin>
More information about the Freeipa-devel
mailing list