[Freeipa-devel] [PATCH] confirm before configuring client

Karl MacMillan kmacmill at redhat.com
Wed Dec 12 16:06:37 UTC 2007


On Wed, 2007-12-12 at 10:47 -0500, Rob Crittenden wrote:
> Karl MacMillan wrote:
> > Confirm before client configuration.
> > 
> > 
> > ------------------------------------------------------------------------
> > 
> > _______________________________________________
> > Freeipa-devel mailing list
> > Freeipa-devel at redhat.com
> > https://www.redhat.com/mailman/listinfo/freeipa-devel
> 
> One minor suggestion: make it yesno.lower()[0] != "y":
> 
> And will it handle it if the user doesn't enter anything?
> 
> It should probably be:
> 
> if not yesno or yesno.lower()[0] != "y":
> 

Pushed with the attached patch to clean this up.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: improve-confirmation.patch
Type: text/x-patch
Size: 2126 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20071212/c5cef50f/attachment.bin>


More information about the Freeipa-devel mailing list