[Freeipa-devel] [PATCH] fix auto-suggest code

[Kevin McCarthy]

Fixes from Dan's feedback.  Non-roundtrip code goes before the ajax
calls.  Also found a dumb bug with the initials code.

-Kevin

-------------- next part --------------
# HG changeset patch
# User Kevin McCarthy <kmccarth at redhat.com>
# Date 1191533035 25200
# Node ID 181fd4fed78c68a7079e9d7eeb7c8a109db337f6
# Parent  472e4fdf6a838b0c058839281d575794c789cedd
Fix the autosuggest ordering so faster operations go first.
Also fix a bug with the initials autosuggest code.

diff -r 472e4fdf6a83 -r 181fd4fed78c ipa-server/ipa-gui/ipagui/templates/usernewform.kid
--- a/ipa-server/ipa-gui/ipagui/templates/usernewform.kid	Thu Oct 04 13:53:16 2007 -0700
+++ b/ipa-server/ipa-gui/ipagui/templates/usernewform.kid	Thu Oct 04 14:23:55 2007 -0700
@@ -101,6 +101,26 @@ from ipagui.helpers import ipahelper
               var cn = $('form_cn');
               var displayname = $('form_displayname');
               var initials = $('form_initials');
+
+              if ((cn.value == "") || (cn.value == cn_suggest)) {
+                cn.value = givenname.value + " " + sn.value;
+                cn_suggest = cn.value;
+                new Effect.Highlight(cn);
+              }
+
+              if ((displayname.value == "") ||
+                  (displayname.value == displayname_suggest)) {
+                displayname.value = givenname.value + " " + sn.value;
+                displayname_suggest = displayname.value;
+                new Effect.Highlight(displayname);
+              }
+
+              if ((initials.value == "") ||
+                  (initials.value == initials_suggest)) {
+                initials.value = givenname.value[0] + sn.value[0];
+                initials_suggest = initials.value;
+                new Effect.Highlight(initials);
+              }
 
               if ((uid.value == "") || (uid.value == uid_suggest)) {
                 new Ajax.Request('${tg.url('/suggest_uid')}', {
@@ -124,26 +144,6 @@ from ipagui.helpers import ipahelper
                         new Effect.Highlight(mail);
                       }
                     });
-              }
-
-              if ((cn.value == "") || (cn.value == cn_suggest)) {
-                cn.value = givenname.value + " " + sn.value;
-                cn_suggest = cn.value;
-                new Effect.Highlight(cn);
-              }
-
-              if ((displayname.value == "") ||
-                  (displayname.value == displayname_suggest)) {
-                displayname.value = givenname.value + " " + sn.value;
-                displayname_suggest = displayname.value;
-                new Effect.Highlight(displayname);
-              }
-
-              if ((displayname.value == "") ||
-                  (displayname.value == displayname_suggest)) {
-                initials.value = givenname.value[0] + sn.value[0];
-                initials_suggest = initials.value;
-                new Effect.Highlight(initials);
               }
             }
 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 4054 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20071004/7ed34fe7/attachment.bin>