[Freeipa-devel] [PATCH] Don't allow default service principals to be removed

[Rob Crittenden]

David Hollis wrote:
> On Fri, 2008-04-25 at 16:58 -0400, Rob Crittenden wrote:
>>          if entry is None:
>>              raise ipaerror.gen_exception(ipaerror.LDAP_NOT_FOUND)
>> +        dn_list = ldap.explode_dn(entry['dn'].lower())
>> +        if "cn=kerberos" in dn_list:
>> +            raise ipaerror.gen_exception(ipaerror.LDAP_NOT_FOUND)
> 
> I don't know squat about python, but should the exception thrown be
> LDAP_NOT_FOUND or should it be INPUT_SERVICE_PRINCIPAL_REQUIRED that was
> defined higher up in the patch?
> 
> 

Ack, nice catch. I'll fix it up and resubmit.

rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3245 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20080425/8418bac5/attachment.bin>