[Freeipa-devel] [PATCH] restructure tools
Simo Sorce
ssorce at redhat.com
Wed Feb 27 22:08:50 UTC 2008
On Wed, 2008-02-27 at 10:42 -0500, Rob Crittenden wrote:
> This is a potentially disruptive patch to all the admin tools. I
> wanted
> to be able to catch KeyboardInterrupt but I needed to move all the
> imports under a try/except in order to catch it in all cases. If one
> interrupted early enough you'd catch it in the import phase which
> wasn't
> covered.
>
> So I moved all the imports into a main try/except which calls our
> main.
> I moved most other exceptions out of main into this top level
> try/except
> to make the individual functions more readable.
>
> I also found a difference in the way GSSError is handled in python
> 2.4
> and python 2.5 so I added a small helper to deal with it.
Wow, huge beast, but seem fine.
Haven't gone through every single line, just reviewed the general
changes, I trust you tested every single corner case :-P
Simo.
--
Simo Sorce * Red Hat, Inc * New York
More information about the Freeipa-devel
mailing list