[Freeipa-devel] [Patch] Re-base memberOf plug-in off of current FDS memberOf plug-in

[Rob Crittenden]

Nathan Kinder wrote:
> This fixes many, many issues with the memberOf plug-in.
> 
> -NGK
> 
>

Wow, a lot to go through. I think I grok most of this.

A couple of comments/questions.

Most of the functions are renamed in a more generic way, I'm presuming 
to make it easier to keep in sync with the FDS version of the plugin, right?

But some functions weren't renamed, ipamo_postop_init() for one. Do we 
want to go ahead and do that?

Some comment blocks look really strange in the patch too:

- * Online tasks interface (to support import, export, etc)
- * After some cleanup, we could consider making these public.
- */
+ *  * Online tasks interface (to support import, export, etc)
+ *   * After some cleanup, we could consider making these public.
+ *    */

What is the purpose of dont_allow_that()?

rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3245 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20080718/de41db55/attachment.bin>