[Freeipa-devel] [PATCH] check for duplicate phone numbers

[Dmitri Pal]

Nathan Kinder wrote:
> Dmitri Pal wrote:
>> Rob Crittenden wrote:
>>> Dmitri Pal wrote:
>>>> Michael DeHaan wrote:
>>>>> Rob Crittenden wrote:
>>>>>> Do uniqueness check on phone numbers entered via the UI.
>>>>>> rob
>>>>>> ------------------------------------------------------------------------ 
>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> Freeipa-devel mailing list
>>>>>> Freeipa-devel at redhat.com
>>>>>> https://www.redhat.com/mailman/listinfo/freeipa-devel
>>>>>
>>>>> Completely lurking here, but might people might share a phone in 
>>>>> some cases?
>>>>> Pagers can also be shared too.
>>>>>
>>>>> --Michael
>>>> This is about having one and the same number listed multiple times 
>>>> in the same multi value attribute.
>>>> It does not make sense have to have to cell phone records with same 
>>>> number.
>>>> This is what the bug is about. Rob did you interpret it this way?
>>>
>>> No. It also allowed the same phone number to be entered multiple 
>>> times in the same field which would cause LDAP to throw an error 
>>> (some obscure thing about types).
>>>
>>> I don't think it is a bad thing to have the same phone number listed 
>>> in multiple fields, it may very well be the case that their pager is 
>>> a cell phone.
>>>
>>> Simo pointed out that we shouldn't limit this test to phone numbers 
>>> either. The full name field is also multi valued.
>>>
>>> rob
>>
>>
>> I think the two issues got mixed.
>> 1) It is bad to allow same values in the one multivalue attribute. 
>> For example allow two values for phone attribute with the same phone 
>> number.
> I'll add that LDAP doesn't allow it (which is the error Rob pointed 
> out).  We just want to catch it in the UI ahead of time to prevent an 
> ugly LDAP error.
>> 2) It is Ok to have one and the same value  across different 
>> attributes.  Cell can be = pager and phone  can be = fax
>>
>>
>>
>


Ok, I agree.

-- 
Dmitri Pal
Engineering Manager
Red Hat Inc.