[Freeipa-devel] [PATCH] Invoke shadow-utils from sss_tools for legacy domains

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jakub Hrozek wrote:
> The attached patch addresses ticket #23. A few comments:
> 
> * when adding, the legacy tools are used when user selects ID from
> legacy domain or outside any domain
> * changing IDs is allowed only inside the same domain
> * whether a domain is legacy proxying to files is determined by looking
> directly to confdb if provider is set to "proxy" and libName to "files"
> 
> Jakub
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel

Nack.

Shadow utils path needs to be a configure option, since it may not be in
sbindir on all platforms.

In is_domain_local_legacy(), you check twice for
strcasecmp(dom->provider, "proxy"). The second one (ANDed with the check
for "files") is completely redundant, because it's sitting within the
block from the previous check, and dom has not changed.



- --
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iEYEARECAAYFAkn1lc8ACgkQeiVVYja6o6MLdgCePBkhNO0q7gWQJs+VzoyoZY6t
uP4An1aU+v3Dm+XT9luZHfS/w3ir8ezR
=IF2g
-----END PGP SIGNATURE-----