[Freeipa-devel] [PATCHES] start/stop related fixes

Jakub Hrozek jhrozek at redhat.com
Thu Apr 30 15:49:52 UTC 2009


Hi,
attached are four small fixes (separately b/c they fix different issues)
that deal with start and stop sequence of sssd.

The first one reads the config file before calling server_setup() which
daemonizes, so errors in config file are caught before becoming a
daemon. Would it make sense to do as many configuration steps (from
monitor_process_init() - like actually initializing confdb etc.) as
possible before the daemonization?

Fix initscript return codes is pretty straightforward - just return
correct values in initscript functions. These two patches should address
ticket #28.

The third one redirects stderr when starting sssd to a temporary logfile
and only prints it when something fails during the startup. This should
address ticket #27.

The last one removes the pid file on quitting sssd, right now the pid
file is left in /var/run after sssd finished which doesn't seem right.
Related to this - should sssd be a single-instance daemon? If so,
there's another bug in pidfile() - a second instance of sssd that's ran
overwrites the pid file. 

Jakub
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Read-the-config-before-startup.patch
Type: text/x-patch
Size: 2015 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20090430/5094ec9b/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Fix-initscript-return-codes.patch
Type: text/x-patch
Size: 1136 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20090430/5094ec9b/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-redirect-stderr-to-logfile-in-initscript.patch
Type: text/x-patch
Size: 906 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20090430/5094ec9b/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Remove-pidfile-on-SIGTERM-and-SIGINT.patch
Type: text/x-patch
Size: 1962 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20090430/5094ec9b/attachment-0003.bin>


More information about the Freeipa-devel mailing list