[Freeipa-devel] [PATCH] 250 fix some pylint/pychecker errors

[Rob Crittenden]

Taking David Malcolm's advice I ran pylint and pychecker against a lot 
of the IPA code. Much of what it turned up was warnings/complaints about 
variable names, minor formatting, things like that. But it did also turn 
up a few bugs (using undefined exceptions, some references to 
non-existent variables, etc).

There are still a lot of places where we shadow built-in functions 
(filter is a common one). I see this as a first-pass at it.

I'll consider trying to come up with a config file we can pass to this 
so we can do some sort of 'make check' to catch errors. Right now the 
output is so copious it is difficult to tell wheat from chaff without 
reading carefully.

rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-250-lint.patch
Type: application/mbox
Size: 23115 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20090811/c103092a/attachment.mbox>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3245 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20090811/c103092a/attachment.bin>