[Freeipa-devel] [PATCHES] Support for RPM generation in SSSD

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jakub Hrozek wrote:
> On Thu, 2009-02-12 at 15:59 -0500, Stephen Gallagher wrote:
>> New patch attached with recommended changes. Please re-review.
> 
> I did some minor tweaks to the specfile and Makefile, patch attached.
> Also, whether PolicyKit and InfoPipe support are built is now
> configurable. This patch is applicable on current master, if an
> iterative patch against Stephen's is more comfortable for you, I have
> that in my repo[1]

Patches should definitely be from the master, as my patch was a
work-in-progress that you've taken over. So this is fine.

> rpmlint now outputs this:
> ---
> sssd.i386: W: no-documentation
> sssd.i386: W:
> non-conffile-in-etc /etc/dbus-1/system.d/org.freeipa.sssd.infopipe.conf
> sssd.i386: W: no-soname /usr/lib/libsss_proxy.so
> sssd.i386: W: no-soname /usr/lib/memberof.so
> sssd.i386: W: no-soname /usr/lib/libsysdb.so
> 1 packages and 0 specfiles checked; 0 errors, 5 warnings.
> ---
> 
> I think that's OK, there really is no documentation so far, dbus conf
> files are typically not marked as %config and no-soname is not a
> packaging issue, I think.

We should probably be building the shared objects with '-Wl
- -soname,<SONAME>'

> Jakub
> 
> [1]
> http://fedorapeople.org/gitweb?p=jhrozek/public_git/sssd.git;a=summary
> 
> 

I'd prefer if you used HAVE_INFOPIPE and HAVE_POLICYKIT as the macros.


- --
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iEYEARECAAYFAkmcocIACgkQeiVVYja6o6PeswCgqgPG9kBr5xjHl6IXxZYqcfzr
8aEAoIbF5uxkE71e1B/aziYGK1UCDYNW
=/Rpw
-----END PGP SIGNATURE-----