[Freeipa-devel] [PATCH] Stack and Queue APIs using collection

[Dmitri Pal]

John Dennis wrote:
>>> I've also opened https://fedorahosted.org/sssd/ticket/69 (tangentially
>>> related). The collection API has the potential for namespace collision
>>> with programs attempting to import it, so we should clear that up. This
>>> patch made me aware of it, but it's true of the pre-existing code, so
>>> it'll be better to fix it all at once.
>
>> I understand the motivation. Is it really the best practice?
>
> yes, it is common to use short prefix for all symbols in languages
> which do not support namespaces (e.g. C) in order to create a pseudo
> namespace, and yes it's good practice.
>
>> property - a key value pair
>> item - property in a internal representation of the collection (think
>> turned into an object)
>> collection  - set of items and other collections
>
>> So names are constructed from these terms and actions (sometimes with
>> preposition and type):
>> insert_str_property
>> modify_bool_item
>> create_collection
>
>> If we follow the proposal in the ticket we would have:
>> col_create_collection - looks a bit strange to me. Is it Ok with
>> everybody?
>
> O.K. with me.
>
Ok massive patch is coming today then.
Line up for review. :-)

-- 
Thank you,
Dmitri Pal

Engineering Manager IPA project,
Red Hat Inc.


-------------------------------
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/