[Freeipa-devel] [PATCH] First part of the ELAPI interface (resend)

[Dmitri Pal]

Sumit Bose wrote:
> On Mon, Jul 13, 2009 at 07:42:26PM -0400, Dmitri Pal wrote:
>   
>> Dmitri Pal wrote:
>>     
>>> This is just a part of the interface,
>>> a beginning. Most likely some of the functions
>>> will be altered but it is a starting point.
>>> For example in future there will be
>>> a way to override some of the parts of the
>>> default template using the application configuration file.
>>>
>>>
>>> I just need to start somewhere. More to come during the week.
>>>
>>>   
>>>       
>> Forgot the attachment...
>>
>>     
>
> Just a few general comments for a start.
> - I think you have to add the m4 subdirectory to the repository, too.
>   autoreconf does not create it automatically
>   
I noticed that too but thought it is a problem with my configuration.
Steven is that the case?

> - please change configure.ac and Makefile.am according to Stephen's
>   recent patch to include all thew usual -W* flags to AM_CFLAGS
>   
I can do it in a separate patch on top of this one.
No need to jam things together. But I will take a look.

> - I get a "'COL_ADD_MODE_FLAT' undeclared"
>   
It is declared in one of the two previous patches I submitted.
They have not been pushed yet. You need all three for things to work.
On relies on another.

Thanks for taking a look.

> bye,
> Sumit
>   


-- 
Thank you,
Dmitri Pal

Engineering Manager IPA project,
Red Hat Inc.


-------------------------------
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/