[Freeipa-devel] [PATCH] COLLECTION Improving searches

[Dmitri Pal]

Stephen Gallagher wrote:
> On 07/15/2009 05:34 PM, Dmitri Pal wrote:
> > Addressing ticket https://fedorahosted.org/sssd/ticket/71
>
>
>
> > ------------------------------------------------------------------------
>
> > _______________________________________________
> > Freeipa-devel mailing list
> > Freeipa-devel at redhat.com
> > https://www.redhat.com/mailman/listinfo/freeipa-devel
>
> You've added a check in col_find_item_and_do() for a trailing '.', which
> is illegal, but you didn't add a corresponding unit test to verify that
> this is behaving as expected.
>
> Please add that unit test, then this will be an ack.
>
Sure, what about other two patches?
Anything needs to be corrected there?
I would prefer to make changes in one pass if possible.
Also the question is: since the patches are relatively small can I
squash them together?
I am not sure I want to do it but I wanted to ask anyways what the best
approach is.
_______________________________________________
Freeipa-devel mailing list
Freeipa-devel at redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel




-- 
Thank you,
Dmitri Pal

Engineering Manager IPA project,
Red Hat Inc.


-------------------------------
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/