[Freeipa-devel] [PATCH] Stack and Queue APIs using collection

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 07/02/2009 08:06 AM, Stephen Gallagher wrote:
> On 07/01/2009 06:25 PM, Dmitri Pal wrote:
>> Patch adds two convenience interfaces that  allow using collection as a
>> queue or as a stack.
> 
> 
> 
> 
> 
>> ------------------------------------------------------------------------
> 
>> _______________________________________________
>> Freeipa-devel mailing list
>> Freeipa-devel at redhat.com
>> https://www.redhat.com/mailman/listinfo/freeipa-devel
> 
> I will ack this and commit it but I'm going to fix two things:
> 
> 1) Formatting bug: every "return error;" line in collection_queue.c and
> collection_stack.c is prepended by a tab instead of four spaces. There's
> also one in queue test before "unsigned count;"
> 
> 2) Trace messages are wrong for enqueue_any_property.
> 
> I've also opened https://fedorahosted.org/sssd/ticket/69 (tangentially
> related). The collection API has the potential for namespace collision
> with programs attempting to import it, so we should clear that up. This
> patch made me aware of it, but it's true of the pre-existing code, so
> it'll be better to fix it all at once.

Pushed to master.
_______________________________________________
Freeipa-devel mailing list
Freeipa-devel at redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


- -- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkpMpW0ACgkQeiVVYja6o6MkpQCcDZZtTH5y0riySjF3YKhLkaUT
6z0AnjowpcpZqMsYMSmgUcBohdk7ZncO
=hjkr
-----END PGP SIGNATURE-----