[Freeipa-devel] Re: [PATCH] Fix bug: when deleting hosts, their services were deleted incorrectly

Pavel Zuna pzuna at redhat.com
Thu Jul 2 13:14:02 UTC 2009


Rob Crittenden wrote:
> Pavel Zuna wrote:
>>
>> Pavel
> 
> I gather this is to handle the case where the incoming hostname could be 
>  not fully qualified?
> 
> Should we have a normalizer to always make the hostname lower-case?
> 
> rob
No, the problem was that services for the host being deleted were searched for 
incorrectly - even services for other hosts can be returned if the service name 
contains the hostname. I just added check so it doesn't happen.

The normalizer is already there, I just didn't notice. The line:

hostname = hostname.lower()

is redundant.

Pavel




More information about the Freeipa-devel mailing list