[Freeipa-devel] Re: [PATCH] Fix bug: when deleting hosts, their services were deleted incorrectly

[Rob Crittenden]

Pavel Zuna wrote:
> Rob Crittenden wrote:
>> Pavel Zuna wrote:
>>>
>>> Pavel
>>
>> I gather this is to handle the case where the incoming hostname could 
>> be  not fully qualified?
>>
>> Should we have a normalizer to always make the hostname lower-case?
>>
>> rob
> No, the problem was that services for the host being deleted were 
> searched for incorrectly - even services for other hosts can be returned 
> if the service name contains the hostname. I just added check so it 
> doesn't happen.

Ah, nice catch. If you had a host named ldap bad things woudl happen :-)

> The normalizer is already there, I just didn't notice. The line:
> 
> hostname = hostname.lower()
> 
> is redundant.
> 
> Pavel

Ok, ack.

rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3245 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20090702/4a501bc1/attachment.bin>