[Freeipa-devel] [PATCH 0/3] sssd: Rework sysdb to use tevent_req async style

[Sumit Bose]

On Thu, Jul 02, 2009 at 07:21:51PM -0400, Simo Sorce wrote:
> Hello all,
> 
> While working on the native ldap driver I found it increasingly
> cumbersome to use the current sysdb transactional code and callbacks.
> 
> After some major thinking I decided it would be useful to convert sysdb
> to use the tevent_req async style.
> 
> This style uses a few conventions that make async programming a lot
> easier in my opinion.
> 
> What follows are three patches:
> 1. Prep code renames sysdb_req to sysdb_handle to better reflect what
> this structure actually is and avoid confusion with tevent_req
> 2. Convert all sysdb code to use tevent_req async style
> 3. Convert the proxy backend
> 
> They can be applied one at a time and all should keep working.
> I've tested all operations with all 3 applied together and everything
> seem working.
> 

I have tested them together and have not found any issues. Therefore

ACK
ACK
ACK


> I have not yet converted the responder and the sysdb_getXXyyy calls
> (except for minor internal adjustments), not sure if it is worth
> changing that interface yet.
> 

I think it would make sense to have only one interface. Shall I take the
pam responder?

> I may convert the backends interfaae to use directly a tevent_req style
> later, but preferred to go in steps. I might propose such a patch
> together with the ldap driver.
> 

+1
This will underline that the backends have to be asynchronous and have
to/should use tevent to achieve this.


Thanks for the redesign. I'm looking forward to the new LDAP backend.

bye,
Sumit

> -- 
> Simo Sorce * Red Hat, Inc * New York
> 
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel