[Freeipa-devel] [PATCH] cleanups

Simo Sorce ssorce at redhat.com
Fri Jul 3 16:48:22 UTC 2009


To all,
I have done janitorial work to fix lots and lots of warnings (mainly in
common/collection) in the following 2 patches.

We have only 1 warning left in collection (I will need to discuss this
one with Dmitri next week).

Please,
before submitting a patch do a complete build from scratch using the
following command:

make CFLAGS="-Wall -Wshadow -Wstrict-prototypes -Wpointer-arith
-Wcast-qual -Wcast-align -Wwrite-strings" LIBTOOLFLAGS=--silent --quiet

If you see any output but "Making all in <subsystem>" then you have a
bug to fix before sending the patch in for review.

cheers,
Simo.

-- 
Simo Sorce * Red Hat, Inc * New York
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Clean-up-warnings-in-common.patch
Type: text/x-patch
Size: 46291 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20090703/49176e9e/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Cleanup-warnings-in-client-and-server-code.patch
Type: text/x-patch
Size: 2452 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20090703/49176e9e/attachment-0001.bin>


More information about the Freeipa-devel mailing list