[Freeipa-devel] [PATCH] cleanups

[Dmitri Pal]

Simo Sorce wrote:
> To all,
> I have done janitorial work to fix lots and lots of warnings (mainly in
> common/collection) in the following 2 patches.
>
>   
Thank you. But why they do not show up automatically in the normal build?
I trust whatever Steven has setup as the default build and I do not see
any warnings otherwise I would have addressed them.

> We have only 1 warning left in collection (I will need to discuss this
> one with Dmitri next week).
>
>   
I am just used to checking free(). In old times it was dangerous to free
without checking.
I do not know how porting to other platforms would go down the road.
It might be that we would have to use other compiler on other platforms
and it might not be as smart.
Also I suspect that smart compiler probably optimizes the code so the
duplicate checking is removed.
It is a bit of defensive programming. If you think it is not worth
checking nowadays I will stop doing it.


> Please,
> before submitting a patch do a complete build from scratch using the
> following command:
>
> make CFLAGS="-Wall -Wshadow -Wstrict-prototypes -Wpointer-arith
> -Wcast-qual -Wcast-align -Wwrite-strings" LIBTOOLFLAGS=--silent --quiet
>
>   
This should be baked into the configure so it can be easily turned off
and on (if not be on by default).



> If you see any output but "Making all in <subsystem>" then you have a
> bug to fix before sending the patch in for review.
>
> cheers,
> Simo.
>
>   
> ------------------------------------------------------------------------
>
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel


-- 
Thank you,
Dmitri Pal

Engineering Manager IPA project,
Red Hat Inc.


-------------------------------
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/