[Freeipa-devel] [PATCH] fixed a double talloc_free error

[Sumit Bose]

Hi,

this patch fixes a double talloc_free error in the sss tools. The
sysdb_transaction_commit_recv call free the handle already.

bye,
Sumit
-------------- next part --------------
>From 2bdaf1c7316eeb5c9fc68f0ff6cd0e7487730f6e Mon Sep 17 00:00:00 2001
From: Sumit Bose <sbose at redhat.com>
Date: Wed, 8 Jul 2009 13:02:44 +0200
Subject: [PATCH] fixed a double talloc_free error

---
 server/tools/sss_groupadd.c |    2 --
 server/tools/sss_groupdel.c |    2 --
 server/tools/sss_groupmod.c |    2 --
 server/tools/sss_useradd.c  |    2 --
 server/tools/sss_userdel.c  |    2 --
 server/tools/sss_usermod.c  |    2 --
 6 files changed, 0 insertions(+), 12 deletions(-)

diff --git a/server/tools/sss_groupadd.c b/server/tools/sss_groupadd.c
index 7050567..40df8c9 100644
--- a/server/tools/sss_groupadd.c
+++ b/server/tools/sss_groupadd.c
@@ -65,8 +65,6 @@ static void add_group_req_done(struct tevent_req *req)
 
     data->error = sysdb_transaction_commit_recv(req);
     data->done = true;
-
-    talloc_zfree(data->handle);
 }
 
 static void add_group_terminate(struct group_add_ctx *data, int error)
diff --git a/server/tools/sss_groupdel.c b/server/tools/sss_groupdel.c
index 50ed112..7b65b7d 100644
--- a/server/tools/sss_groupdel.c
+++ b/server/tools/sss_groupdel.c
@@ -64,8 +64,6 @@ static void groupdel_req_done(struct tevent_req *req)
 
     data->error = sysdb_transaction_commit_recv(req);
     data->done = true;
-
-    talloc_zfree(data->handle);
 }
 
 /* sysdb callback */
diff --git a/server/tools/sss_groupmod.c b/server/tools/sss_groupmod.c
index 30f8e54..9f6a974 100644
--- a/server/tools/sss_groupmod.c
+++ b/server/tools/sss_groupmod.c
@@ -70,8 +70,6 @@ static void mod_group_req_done(struct tevent_req *req)
 
     data->error = sysdb_transaction_commit_recv(req);
     data->done = true;
-
-    talloc_zfree(data->handle);
 }
 
 static void mod_group_done(struct group_mod_ctx *data, int error)
diff --git a/server/tools/sss_useradd.c b/server/tools/sss_useradd.c
index e78e11c..f9482aa 100644
--- a/server/tools/sss_useradd.c
+++ b/server/tools/sss_useradd.c
@@ -196,8 +196,6 @@ static void add_user_req_done(struct tevent_req *req)
 
     data->error = sysdb_transaction_commit_recv(req);
     data->done = true;
-
-    talloc_zfree(data->handle);
 }
 
 static void add_user_terminate(struct user_add_ctx *data, int error)
diff --git a/server/tools/sss_userdel.c b/server/tools/sss_userdel.c
index 857057f..5e400fc 100644
--- a/server/tools/sss_userdel.c
+++ b/server/tools/sss_userdel.c
@@ -63,8 +63,6 @@ static void userdel_req_done(struct tevent_req *req)
 
     data->error = sysdb_transaction_commit_recv(req);
     data->done = true;
-
-    talloc_zfree(data->handle);
 }
 
 /* sysdb callback */
diff --git a/server/tools/sss_usermod.c b/server/tools/sss_usermod.c
index 1b1478a..05df133 100644
--- a/server/tools/sss_usermod.c
+++ b/server/tools/sss_usermod.c
@@ -107,8 +107,6 @@ static void mod_user_req_done(struct tevent_req *req)
 
     data->error = sysdb_transaction_commit_recv(req);
     data->done = true;
-
-    talloc_zfree(data->handle);
 }
 
 static void mod_user_done(struct user_mod_ctx *data, int error)
-- 
1.6.2.5