[Freeipa-devel] [PATCH] First part of the ELAPI interface (resend)

[Simo Sorce]

On Mon, 2009-07-13 at 19:42 -0400, Dmitri Pal wrote:
> Dmitri Pal wrote:
> > This is just a part of the interface,
> > a beginning. Most likely some of the functions
> > will be altered but it is a starting point.
> > For example in future there will be
> > a way to override some of the parts of the
> > default template using the application configuration file.
> >
> >
> > I just need to start somewhere. More to come during the week.

Haven't read everything, but I saw a couple of things that are not ok.
1. the public header requires the private header, this is a nack.
2. Never, ever typedef to a pointer.

typedef struct foo foo_t    is ok if really necessary
typedef struct foo * foo_t  is an instant-nack

Simo.


-- 
Simo Sorce * Red Hat, Inc * New York