[Freeipa-devel] [PATCH] First part of the ELAPI interface (resend 2)

[Dmitri Pal]

Dmitri Pal wrote:
> Simo Sorce wrote:
>   
>> On Mon, 2009-07-13 at 19:42 -0400, Dmitri Pal wrote:
>>   
>>     
>>> Dmitri Pal wrote:
>>>     
>>>       
>>>> This is just a part of the interface,
>>>> a beginning. Most likely some of the functions
>>>> will be altered but it is a starting point.
>>>> For example in future there will be
>>>> a way to override some of the parts of the
>>>> default template using the application configuration file.
>>>>
>>>>
>>>> I just need to start somewhere. More to come during the week.
>>>>       
>>>>         
>> Haven't read everything, but I saw a couple of things that are not ok.
>> 1. the public header requires the private header, this is a nack.
>> 2. Never, ever typedef to a pointer.
>>
>> typedef struct foo foo_t    is ok if really necessary
>> typedef struct foo * foo_t  is an instant-nack
>>
>> Simo.
>>
>>
>>   
>>     
> We had a phone conversation and decided that we will not try to hide the
> "struct collection_item *" behind typedefs at all.
> I will amend the patch accordingly.
>
>   
* Removed the obfuscation of data types based on discussion with Simo.
* Changed header file inclusion - private header is private.
* Changed compilation flags
* Added m4 directory following Steven's method.

Patch works only on top of previous two patches.

-- 
Thank you,
Dmitri Pal

Engineering Manager IPA project,
Red Hat Inc.


-------------------------------
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ELAPI-First-part-of-the-interface.patch
Type: text/x-patch
Size: 62820 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20090714/29e7be6f/attachment.bin>