[Freeipa-devel] [PATCH] COLLECTION Improving searches

Stephen Gallagher sgallagh at redhat.com
Thu Jul 16 10:59:26 UTC 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 07/15/2009 05:34 PM, Dmitri Pal wrote:
> Addressing ticket https://fedorahosted.org/sssd/ticket/71
> 
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel

You've added a check in col_find_item_and_do() for a trailing '.', which
is illegal, but you didn't add a corresponding unit test to verify that
this is behaving as expected.

Please add that unit test, then this will be an ack.

- -- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkpfCAkACgkQeiVVYja6o6O/lACfaabQZWLNQZTQYx1LELrfWU/Z
aiUAoKChUHnS0BFgqxBlqGHM4PTMby2P
=VaU0
-----END PGP SIGNATURE-----




More information about the Freeipa-devel mailing list