[Freeipa-devel] Re: [PATCH] COLLECTION Improving searches (resending)

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 07/16/2009 05:17 PM, Dmitri Pal wrote:
> Stephen Gallagher wrote:
>> On 07/16/2009 09:29 AM, Dmitri Pal wrote:
>>> Stephen Gallagher wrote:
>>>> On 07/15/2009 05:34 PM, Dmitri Pal wrote:
>>>>> Addressing ticket https://fedorahosted.org/sssd/ticket/71
>> ------------------------------------------------------------------------
>>>>> _______________________________________________
>>>>> Freeipa-devel mailing list
>>>>> Freeipa-devel at redhat.com
>>>>> https://www.redhat.com/mailman/listinfo/freeipa-devel
>>>> You've added a check in col_find_item_and_do() for a trailing '.',
>> which
>>>> is illegal, but you didn't add a corresponding unit test to verify that
>>>> this is behaving as expected.
>>>>
>>>> Please add that unit test, then this will be an ack.
>>>>
>>> Sure, what about other two patches?
>>> Anything needs to be corrected there?
>>> I would prefer to make changes in one pass if possible.
>>> Also the question is: since the patches are relatively small can I
>>> squash them together?
>>> I am not sure I want to do it but I wanted to ask anyways what the best
>>> approach is.
>>> _______________________________________________
>>> Freeipa-devel mailing list
>>> Freeipa-devel at redhat.com
>>> https://www.redhat.com/mailman/listinfo/freeipa-devel
>>
>>
>>
>>
>> The general rule we follow with patches is that it should be one patch
>> per logical change. Only squash patches together if they are 100%
>> codependent (i.e. Patch A depends on Patch B, but Patch B also depends
>> on Patch A)
>>
>> I'll look at the other patches. Oddly they didn't show up in my email
>> until about an hour ago. Strange routing glitch, I expect.
>>
> Updated patch attached
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel
> 
> 
> 
> 

Ack and pushed to master.

- -- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkpfm9MACgkQeiVVYja6o6MjQwCglB1vl/pDSW4XyOE8bLD85Uw4
ENUAnRloaqqmhx3JpAFsFa1/LQ8L2TkF
=kymO
-----END PGP SIGNATURE-----