[Freeipa-devel] Proposed modification to C coding standard

John Dennis jdennis at redhat.com
Fri Jul 24 20:14:43 UTC 2009


On 07/24/2009 03:04 PM, Stephen Gallagher wrote:
> I concur (and have mostly been ignoring the previous policy up to this
> point).
>
> The only comment I might make is that it may still be acceptable for
> true single-line if statements, e.g.

yes, I would agree with this.

> str = malloc(10);
> if(!str) return ENOMEM;

However in this particular example I would prefer

if ((str = malloc(10)) == NULL) return ENOMEM;

This keeps it as a true single line and is consistent with:

RECOMMENDED: Use the full condition syntax like (NULL == str) rather 
than (!str).

I think some folks have an issue with this type of compound expression 
but I find it much more readable and expressive of intent, YMMV. FWIW 
the coding standard doesn't cover compound expressions.

-- 
John Dennis <jdennis at redhat.com>

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/




More information about the Freeipa-devel mailing list