[Freeipa-devel] Proposed modification to C coding standard

[Jakub Hrozek]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 07/24/2009 08:57 PM, John Dennis wrote:
> Our coding standards highly recommended *not* using braces following a
> conditional when there is a single expression
> 
> http://freeipa.com/page/Coding_Style#Conditions_and_Statements
> 
> I propose to amend this so that it is highly recommended to always use
> braces.
> 
> Discussion:
> 
> By not using braces to form a block there is an opportunity to introduce
> a bug if a programmer adds another expression and fails to notice braces
> are now needed to preserve program logic. Always using braces is simple
> defensive programming practice and is recommended by many coding
> standards. Practical experience has shown the failure to introduce
> braces when none were there previously is a common mistake which
> introduces bugs often not found until much later, this can be eliminated
> by always using braces, readability is not compromised.
> 

As someone who has been largely ignoring the previous recommendation of
not using braces, +1.

Jakub
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkpq3nIACgkQHsardTLnvCVSxgCfTEJ1cDnIMXpQdQnJRt8jJ57O
UacAoIX85tBjfM6va0tBZo+9KhBeEB5i
=tdh+
-----END PGP SIGNATURE-----