[Freeipa-devel] Re: [PATCHES] Add HBAC plugin port to new LDAP backend.

[David O'Brien]

Rob Crittenden wrote:
> Pavel Zuna wrote:
>> I think this plugin is a good demonstration of what the new base 
>> classes for plugins using LDAP can do. The old plugin was 
>> considerebaly longer and a lot more complex.
>>
>> Patch 0015: Add GeneralisedTime parameter type.
>
> Not sure if it is a Queens english vs American english but shouldn't 
> generalized be spelled with a 'z' instead of an 's' at the end?
All RH documentation uses US English - and consequently "z" here - so it 
would be nice if the docstrings, parameter names, etc., followed suit 
wherever possible.

/David
>
>>
>> I moved time checking code from the old plugin and made a new 
>> auto-validating Param type.
>>
>> Patch 0016: Add HBAC plugin port to new LDAP backend.
>
>
> Looks ok, ack once we work out the spelling.
>
> rob
>
>>
>> Pavel
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel


-- 

David O'Brien
IPA Content Author
Red Hat Asia Pacific
+61 7 3514 8189

"The most valuable of all talents is that of never using two words when
one will do."
   Thomas Jefferson