[Freeipa-devel] [PATCH] check pending_return after dbus_connection_send_with_reply

[Simo Sorce]

On Tue, 2009-06-23 at 15:05 +0200, Sumit Bose wrote:
> Hi,
> 
> according to
> http://dbus.freedesktop.org/doc/dbus/api/html/group__DBusConnection.html#ga951b2a6f6c4069fa392752000b24ebe
> dbus_connection_send_with_reply can return TRUE, but set pending_return
> to NULL. This patch adds a check to protect the following call which try
> to use pending_return.
> 
> I have found this while running some load tests with >40 parallel
> authentication requests.

Your patch will cacth it but the effect is the same (we will ourselves).
Do you know in what cases this can happen and what it means ?

Why does it return true if pending_return is null ?

Is there anything we can do, like loop back and retry 2-3 times before
giving up ?

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York