[Freeipa-devel] [PATCH][SSSD] Implement GetUserAttributes in the InfoPipe

[Stephen Gallagher]

Stephen Gallagher wrote:
> Simo Sorce wrote:
>> On Mon, 2009-03-02 at 08:56 -0500, Stephen Gallagher wrote:
>>> You can't use strdup, because btreemap takes a void *. This is
>>> necessary
>>> so it can hold arbitrary data (see its use in
>>> create_getattr_result_map).
>> If thekeys are void we can turn them into a char *, are we ever going to
>> use keys that are not strings?
> 
> Probably not, but I wanted to leave it expandable in case we discovered
> such a case.
> 
>>> Also, I wasn't using talloc_reference, it's talloc_steal. Yes, I know
>>> that's not ideal either. I'm open to suggestions.
>> talloc_steal() is much worse in this case.
> 
> 
> Can you explain to me what, exactly, is dangerous about
> talloc_reference? It seems to me that calling
> talloc_reference(btreemap_node, btreemap_value) would solve this handily.
> 
> 


Rebased patch atop current master. No other changes.


_______________________________________________
Freeipa-devel mailing list
Freeipa-devel at redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


-- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-Implement-GetUserAttributes-in-the-InfoPipe.patch
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20090302/ee73d9e7/attachment.ksh>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 259 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20090302/ee73d9e7/attachment.sig>