[Freeipa-devel] [PATCH] Fix version extraction in release script

[Stephen Gallagher]

On 05/21/2009 12:09 PM, Jakub Hrozek wrote:
> On Thu, 2009-05-21 at 10:36 -0400, Stephen Gallagher wrote:
>> Actually, I'm going to revise my ack on this. Should we update this
>> script to use "make dist-gzip", since this now works accurately?
>>
> 
> The main difference I see is that git-archive is given a "tree-ish", in
> our case the git tag for the version we're making the archive for and
> will use only that. In contrast, make dist-gzip would tar up everything
> in the current directory.
> 
> I don't have a strong preference between these two. FWIW, attached is a
> version that uses make dist-gzip for generating the tarball..
> 
> Jakub

make dist-gzip doesn't tar up everything in the directory. It tars up
only those files known to automake. (It is an autogenerated make target).

Frankly, the output of git-archive and make dist-gzip should be
identical, or else we have made a mistake in our automake somewhere.

I'd rather use make dist-gzip because it will be more obvious that we
forgot something in the makefiles (because builds from the tar will break).

-- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3258 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20090521/fe253c75/attachment.p7s>