[Freeipa-devel] [PATCH] admiyo-freeipa-0016-sampledata.patch

Pavel Zůna pzuna at redhat.com
Mon Aug 30 16:48:07 UTC 2010


On 2010-08-30 16:01, Adam Young wrote:
> THis patch usese the protocol part of the URL to decide whether or not
> to use sample data. Thus,
>
> file: -> use sample data
>
> http:, https: -> Don't.
>
> This will prevent the use of sample data in the lite-server.
> It also reduces by one the number of page requests back to the server
> upon page load.
>

ACK
for now, but read comment below.

I would rather see the useSampleData assignment outside of ipa.js. Same 
argument as I used with DetailsForm in details.js on IRC last week. It's 
a project specific thing and files, that implement interfaces starting 
with "ipa_", are meant to be independent of everything except the core 
library (ipalib). I'm going to start a new discussion on the list about 
this. Acking for now, because we can always move the code later, and I 
don't want to slow things down.

Pavel




More information about the Freeipa-devel mailing list