[Freeipa-devel] [PATCH] 0025 Restructure startup code for IPA servers

[Simo Sorce]

On Fri, 10 Dec 2010 12:43:59 +0100
Jakub Hrozek <jhrozek at redhat.com> wrote:

> Other comments:
> Since the ipactl script is written in Python and /sbin/service ipa
> $action is called in %preun and %postun we also need to add
> Requires(preun): python and Requires(postun): python.

Added

> Also, I noticed (unrelated to this patch) that we are missing the
> pre/post Requires on chkconfig and initscripts.

Added as well

> Why do we still use chkconfig --add and --del for ipa_kpasswd instead
> of using enabling it in KrbInstance.__enable()?
> 
> What are the second elements in the SERVICE_LIST[service_name] tuples?
> 
> Otherwise looks good and works fine.

New patch attached.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-simo-0025-2-Introduce-ipa-control-script-that-reads-configuratio.patch
Type: text/x-patch
Size: 22338 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20101210/4dde246d/attachment.bin>