[Freeipa-devel] [PATCH] 017 Init smods to prevent crash if encode_keys fails

[Rob Crittenden]

Jakub Hrozek wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> If encode_keys() failed, we would free the variable smods which is
> unitilialized at the time.

Ok, seems simple enough. Ack, pushed to master.

>
> btw I've seen encode_keys() fail on me during ber-encoding of the octet
> part of the key..which is how I found this bug. I'm not able to
> reproduce it ATM and I've been upgrading to 389-ds 1.2.7 just before
> that, so maybe it was related to the upgrade..should I just file a bug
> or check if I can reproduce it again?

Yes, if you can find a reproducer please file a bug.

rob