[Freeipa-devel] [PATCH] Big webUI patch.

[Pavel Zuna]

On 09/15/2010 03:41 PM, Adam Young wrote:
> On 09/15/2010 08:46 AM, Pavel Zůna wrote:
>> Re-based version of the patch attached, that should apply on the
>> current master. It doesn't have the Javascript library files (BBQ,
>> jQ-UI). This makes the patch a lot smaller and easier to process.
>>
>> I'm going to post another patch that does nothing, but adds the
>> library files.
>>
>> Pavel
>
>
> Things to add to the to do list before this can go in:
>
> Netgroups is missing most of their associations
Fixed.

The menu leading to associations was only generated using the 'memberof' 
attribute. Now it uses all attributes in LDAPObject.attribute_members.

> netgroup_show.json has unmerged changes. We should revert to the version
> in the top of tree
Fixed.

netgroup_show.json changes got in by mistake.

> You have removed the author from several files and replaced it with only
> your own.

Only in two files were it made sense:
1) add.js, because I had to rewrite it from scratch completely.
2) details.js, because I started on a reverted version, that didn't have your 
changes (and name) yet. The changes I'm talking about were the addition of 
DetailsForm function, about 20 lines of code (out of witch 10 were copy pasted 
from somewhere else).

I added you as the author on search.js even though it's also pretty much a 
complete rewrite, but I felt that it was based on your ideas. I also didn't 
touch authorship info on associations even though I made more or less
significant changes to it.

I just acted naturally without thinking about it when adding the file headers. 
If you think it's unfair and I forgot to mention you or Endi somewhere, I'm 
sorry and we can fix it no prob.

>
> I posted the diff:
>
>
> https://fedorahosted.org/freeipa/attachment/ticket/41/pzuna-freeipa-0022-3-BIG.patch
>

Pavel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pzuna-freeipa-0022-4-BIG.patch
Type: text/x-patch
Size: 108059 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20100916/14a5a021/attachment.bin>