[Freeipa-devel] [PATCH] 761 Sort entries on *-find commands

[Rob Crittenden]

Martin Kosek wrote:
> On Wed, 2011-03-30 at 17:14 -0400, Rob Crittenden wrote:
>> Sort output on find commands based on the baseldap LDAPSearch class.
>>
>> A couple tests had to be modified to match the new order.
>>
>> ticket 794
>>
>> rob
>
> The patch works fine except the case when entries are being added in
> post_callback. Check this search:
>
> ipa permission-find --permissions=write
>
> The result is not sorted. I suggest moving the sort process after the
> self.POST_CALLBACKS calls.
>
> What about performance issues? May somebody want to disable the sorting?
> (e.g. --nosort option).
>
> Martin

I think the timing would only be a problem if the sizelimit is made very 
large. The amount of time with/without sorting was negligible. I think 
we're safe.

rob