[Freeipa-devel] [PATCH] 850 use pthrea read/write locks instead of NSPR RW locks

Rob Crittenden rcritten at redhat.com
Wed Aug 24 11:41:15 UTC 2011


Martin Kosek wrote:
> On Mon, 2011-08-22 at 11:21 -0400, Rob Crittenden wrote:
>> NSPR PR_RWLocks are not re-entrant, use pthread read-write locks instead.
>>
>> rob
>
> Reference ticket in the commit message is wrong - I think you wanted to
> reference ticket 1635.
>
> This all looks good. But I was thinking - why don't we use the locking
> interface from slapi-plugin.h? I mean slapi_new_rwlock(),
> slapi_rwlock_rdlock etc. implemented in BZ 730387. It would let us
> abstract from underlying locking details (pthread versus NSPR) and just
> use the slapi plugin interface + save possible changes to locking
> mechanism in the future.
>
> Martin
>

The 389-ds team suggested I go ahead with the pthread fix as their api 
may not be complete soon.

rob




More information about the Freeipa-devel mailing list