[Freeipa-devel] [PATCH] 010 Enable update and reset buttons only if dirty

[Endi Sukma Dewata]

On 8/30/2011 7:36 AM, Petr Vobornik wrote:
> https://fedorahosted.org/freeipa/ticket/1697
>
> Original problem:
> Update name of the automount location (Policy -> Automount ->
> custom_location -> Settings -> Update) in the WEBUI refer to an unknown
> command.
>
> Solution:
> Tracking dirty state in field -> section -> details facet.
> 'Reset' and 'Updates' buttons in details facet are enabled only if facet
> is dirty.
>
> Removes the problem above and 'no modification to be performed' annoyance.

The patch works, so it's ACKed and pushed to master and ipa-2-1.

One minor thing, in details.js:322:

   if(!that.update_button.hasClass('action-button-disabled')) {
       that.reset();
   }

It probably should have been a reset_button instead of update_button. 
Right now it doesn't make any difference because both are enabled and 
disabled together, but that might not be the case in the future.

-- 
Endi S. Dewata