[Freeipa-devel] [PATCH] 674 add API version

[Rob Crittenden]

Adam Young wrote:
>   On 01/12/2011 05:17 PM, Rob Crittenden wrote:
>> Rob Crittenden wrote:
>>> Simo Sorce wrote:
>>>> On Wed, 12 Jan 2011 11:03:31 -0500
>>>> Rob Crittenden<rcritten at redhat.com> wrote:
>>>>
>>>>> Add an API version that is enforced both when the server is built (to
>>>>> disallow unexpected API changes) and when clients talk to the server.
>>>>> See the patch for further details.
>>>>>
>>>>> ticket 584
>>>>>
>>>>> rob
>>>>
>>>> Technical nack, API.txt is missing.
>>>>
>>>> Also it would be really nice if we could test the API on build.
>>>> Id the utf8 plugin thing really needed in order to test the api, or
>>>> could we use PYTHON_PATHY and a fake python module by the same name
>>>> just to get through the import w/o getting an exception out ?
>>>>
>>>> Simo.
>>>>
>>>
>>> Updated patch attached.
>>>
>>> I worked around requiring the utf8 plugin so this should be executable
>>> from a fresh git pull and will always validate the api when building.
>>>
>>> I also made a separate patch for the mozldap dependency change (675).
>>>
>>> rob
>>
>> Moved the changes to daemons/configure.ac to patch 675.
>>
>> rob
>>
>>
>> _______________________________________________
>> Freeipa-devel mailing list
>> Freeipa-devel at redhat.com
>> https://www.redhat.com/mailman/listinfo/freeipa-devel
>
>
> Am I correct in understanding that this patch is going to break the
> webUI? We need to put an API version into the JSON RPC as well. This
> would involve a minor change to install/static/ipa.js in the ipa_cmd
> function, but I am not quite sure what to put there.

I think it will be ok. The version isn't mandatory right now.

rob