[Freeipa-devel] [PATCH] admiyo-0141-spinning-wheel.

Endi Sukma Dewata edewata at redhat.com
Fri Jan 14 08:12:29 UTC 2011


On 1/14/2011 2:35 AM, Adam Young wrote:
>

Mostly fine except these minor things:

1. Everytime you click Update on details facet the primary key will
    be prepended to the header. See details.js:664:

       $('h1',that.container).prepend(that.pkey);

2. The hide_activity_icon() invocations in the following methods:
     - ajax_error_handler()
     - http_error_handler()
     - ipa_error_handler()
    are unnecessary because it's been invoked earlier by success_handler
    or error_handler.

-- 
Endi S. Dewata




More information about the Freeipa-devel mailing list