[Freeipa-devel] [PATCH] 0264-HBAC-deny-warning.

[Adam Young]

On 07/06/2011 03:24 PM, Endi Sukma Dewata wrote:
> On 7/6/2011 10:40 AM, Adam Young wrote:
>> Rebased. Also, updated the hbacrule_find.json sample data to show to the
>> deny rules in static view
>
> Some issues:
>
> 1. The red 'deny' text doesn't line up with the colum header or 
> 'allow' text. The padding-left in .hbac-deny-rule class should be 
> removed.
Fixed
>
> 2. The link to the hbac-deny-remove.html on live server is broken. On 
> live server the file is located under /ipa/config path instead of 
> /ipa/html.
Fixed.  Now wokrs in both static and live server
>
> 3. There are untranslated messages in hbac.js lines 1016, 1021, 1025, 
> 1032, 1037. Please mark them with 'I18n' for later clean up.
Not worth the effort for this
>
> 4. Optional: Ideally the setup() in the accessruletype column should 
> call the superclass' setup() then just add the 'hbac-deny-rule' class 
> to the container. For this particular case it's not a problem because 
> the possible values are only 'allow' or 'deny'. However if the column 
> is linked or uses some kind of formatting it will not be rendered 
> correctly.
>
Again, since this is a short term fix, not worth the effort.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-admiyo-0264-3-HBAC-deny-warning.patch
Type: text/x-patch
Size: 21607 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110706/17161abb/attachment.bin>