[Freeipa-devel] [PATCH] 0008 Modify /etc/sysconfig/network on a client when IPA manages hostname

Alexander Bokovoy abokovoy at redhat.com
Fri Jul 29 09:46:12 UTC 2011


On 29.07.2011 12:21, Alexander Bokovoy wrote:
> On 29.07.2011 12:01, Martin Kosek wrote:
>> On Fri, 2011-07-29 at 11:42 +0300, Alexander Bokovoy wrote:
>>> https://fedorahosted.org/freeipa/ticket/1368
>>>
>>> also replaces a tab by spaces in one else statement (cosmetic).
>>
>> This works fine. But I have few suggestion for improvement:
>>
>> 1) Shouldn't we also run `hostname NEW_HOSTNAME` so that the new
>> hostname is properly set on the system?
> Makes sense.
> 
>> 2) I would enhance our man pages/help and state that we are changing the
>> system hostname. Current --hostname option is confusing:
>>
>>        --hostname
>>               The hostname of this server (FQDN).  By  default  of  nodename  from
>>               uname(2) is used.
> Oh, this is not informative at all. I'll get this updated.
Updated patch attached.

-- 
/ Alexander Bokovoy
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: freeipa-abbra-0008-1-ticket-1368.patch
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110729/b6bda145/attachment.ksh>


More information about the Freeipa-devel mailing list