[Freeipa-devel] [PATCH 50/50] Ticket 1718 - Fix Spanish po translation file

[Rob Crittenden]

John Dennis wrote:
> On 10/11/2011 06:06 PM, Rob Crittenden wrote:
>> John Dennis wrote:
>>> There were quite errors in es.po, it was difficult or impossible to
>>> track down where they came from, Transifex does not have good revision
>>> history.
>>>
>>> I fixed about 20% of the msgstr's in the file that had obvious
>>> problems which could be spotted by a non-Spanish speaking person.
>>>
>>
>> I think this should be left as it was:
>>
>> #: ipalib/plugins/config.py:76
>> msgid "searchtimelimit must be -1 or> 1."
>> -msgstr "searchtimelimit debe ser -1 o> 1."
>> +msgstr ""
>
> Why? This isn't where things are formatted for HTML. This string might
> be output on the command line. None of the other translations (nor the
> default English) does HTML escapes in the translation. The HTML escaping
> should occur after fetching the translation if and only if it's being
> inserted into HTML.

Ok, but we don't have to drop the whole thing, just replace > with >?

>>
>> There are some cases where leading white space is remove and a bunch
>> where it is added. Are these ok?
>>
>> @@ -3184,7 +3117,7 @@ msgid ""
>> " "
>> msgstr ""
>> "\n"
>> -"Búsqueda de cuentas de derechod."
>> +" Búsqueda de cuentas de derechod."
>
> The translator modified the leading whitespace. I ran a script which
> forced the leading whitespace in the original string (msgid) to be the
> same in the translation (msgstr). Thus it set the leading whitespace
> back to what it should have been. In many instances it's a non-issue
> because we strip leading and trailing whitespace prior to display.
>

Ok.

rob